Issue 119963002: Clean-up: Replaces gfx::Font with gfx::FontList in ui/app_list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119963002: Clean-up: Replaces gfx::Font with gfx::FontList in ui/app_list. (Closed)

Created:
7 years ago by Yuki

Modified:
6 years, 12 months ago

Reviewers:
tapted

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Clean-up: Replaces gfx::Font with gfx::FontList in ui/app_list. As a part of effort to support multiple fonts, this CL changes methods to take gfx::FontList instead of gfx::Font, and to use new methods. See https://docs.google.com/a/chromium.org/document/d/1D_25fp9B8b9aZJORfAjDIFq61NWvUquZ5xmKH-VcC4k/view BUG=265485 TEST=Run views_unittests, ui_unittests and unit_tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242518

Created: 6 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -28 lines)			Patch
M	ui/app_list/views/app_list_item_view.cc	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	ui/app_list/views/search_result_actions_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/app_list/views/signin_view.h	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	ui/app_list/views/signin_view.cc	View		6 chunks	+21 lines, -15 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/119963002/90001

6 years, 12 months ago (2013-12-26 03:32:34 UTC) #3

Message was sent while issue was closed.

Change committed as 242518