Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(59)

Issue 1199563003: Remove hasResolver() check from Document::updateStyle. (Closed)

Created:
4 years, 10 months ago by esprehn
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove hasResolver() check from Document::updateStyle. The resolver cannot disappear in the middle of a style recalc, lets ASSERT about that and remove the check. I also fixed the crash bug in tracing that oysteine@ found when tracing could be turned on in the middle of style recalc and we'd have missed calling setStatsEnabled at the start of the recalc. BUG=501634 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197513

Patch Set 1 #

Patch Set 2 : Tracing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M Source/core/dom/Document.cpp View 1 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
esprehn
4 years, 10 months ago (2015-06-19 21:52:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199563003/20001
4 years, 10 months ago (2015-06-19 21:53:03 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59866)
4 years, 10 months ago (2015-06-19 22:42:03 UTC) #6
ojan
lgtm
4 years, 10 months ago (2015-06-20 00:57:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199563003/20001
4 years, 10 months ago (2015-06-20 00:57:37 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-20 01:01:26 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197513

Powered by Google App Engine
This is Rietveld 408576698