Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1199543003: Fix tab switch time regression from backgrounded renderers change (Closed)

Created:
5 years, 6 months ago by shrike
Modified:
5 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, nona+watch_chromium.org, penghuang+watch_chromium.org, shuchen+watch_chromium.org, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix tab switch time regression from backgrounded renderers change Switching between tabs is slightly slower after making it possible for the browser to background hidden renderers. It appears the current event sequence is to background the renderer and then have it free up its resources in the GPU process. However in the background state it runs slower and has its I/O throttled, slowing its interaction with the GPU process. This slowdown in turn delays the newly-foregrounded tab's GPU commands, resulting in increased tab switch times. This change reverses the sequence of events that occur when a tab is no longer foreground, freeing resources with the GPU before putting the renderer in the background. This allows the renderer to interact with the GPU at full speed, and complete its cleanup before the newly-foregrounded tab begins issuing commands to the GPU, restoring original tab switch times. BUG=502502 Committed: https://crrev.com/a57db5090fe6a56c17a73bb5adc7562411840ae4 Cr-Commit-Position: refs/heads/master@{#335525}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comment. #

Patch Set 3 : Edit comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
shrike
Hello asvitkine, PTAL
5 years, 6 months ago (2015-06-22 17:10:56 UTC) #2
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/1199543003/diff/1/content/browser/renderer_host/render_widget_host_view_mac.mm File content/browser/renderer_host/render_widget_host_view_mac.mm (right): https://codereview.chromium.org/1199543003/diff/1/content/browser/renderer_host/render_widget_host_view_mac.mm#newcode912 content/browser/renderer_host/render_widget_host_view_mac.mm:912: SuspendBrowserCompositorView(); Nit: Since the order is significant, please ...
5 years, 6 months ago (2015-06-22 17:13:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199543003/40001
5 years, 6 months ago (2015-06-22 17:35:59 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-22 18:11:22 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 18:12:09 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a57db5090fe6a56c17a73bb5adc7562411840ae4
Cr-Commit-Position: refs/heads/master@{#335525}

Powered by Google App Engine
This is Rietveld 408576698