Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 119943002: Revert of refactor emboldenGlyph (Closed)

Created:
7 years ago by benchen
Modified:
7 years ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -27 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 9 chunks +14 lines, -27 lines 0 comments Download
M src/ports/SkFontHost_FreeType_common.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ports/SkFontHost_FreeType_common.cpp View 3 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
benchen
Created Revert of refactor emboldenGlyph
7 years ago (2013-12-20 13:38:10 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years ago (2013-12-20 13:38:18 UTC) #2
benchen
Looks like I'll need a LGTM to perform this revert. Someone help? Also seems I'm ...
7 years ago (2013-12-20 13:44:38 UTC) #3
rmistry
LGTM
7 years ago (2013-12-20 13:52:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bensong@google.com/119943002/1
7 years ago (2013-12-20 13:52:49 UTC) #5
commit-bot: I haz the power
Change committed as 12794
7 years ago (2013-12-20 13:52:57 UTC) #6
benchen
6 years, 12 months ago (2013-12-26 15:49:39 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/117963003/ by bensong@google.com.

The reason for reverting is: False alert on zheng.xu's original CL - it didn't
break anything..

Powered by Google App Engine
This is Rietveld 408576698