Issue 1199413009: Make helper functions compatible with larger ToBooleanStub types.

Issue 1199413009: Make helper functions compatible with larger ToBooleanStub types. (Closed)

Created:
5 years, 6 months ago by bbudge

Modified:
5 years, 6 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Make helper functions compatible with larger ToBooleanStub types. I missed some functions that need to change. LOG=N BUG=v8:4124 Committed: https://crrev.com/9b36c6e37aac7367794e6e975839f7917ae55f75 Cr-Commit-Position: refs/heads/master@{#29276}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -9 lines)			Patch
M	src/ast.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/type-info.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/type-info.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

Benedikt Meurer

LGTM. Unfortunately you never know for sure whether you fixed all relevant uses. :-(

5 years, 6 months ago (2015-06-25 04:29:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199413009/1

5 years, 6 months ago (2015-06-25 04:30:07 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-25 04:32:32 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9b36c6e37aac7367794e6e975839f7917ae55f75
Cr-Commit-Position: refs/heads/master@{#29276}