Add ListContainer::swap

Add ListContainer::swap

This patch implements a simple swap function on ListContainer. Users
can use this function to swap a list container with... wait for it...
another list container!

BUG=484943
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/d012546071380244dcadedbd4dc1eccaab004d00
Cr-Commit-Position: refs/heads/master@{#335977}

[pdr., 2015-06-24 17:48:03]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, danakj@chromium.org

[danakj, 2015-06-24 17:50:26]

> TEST=ListContainerTest.Swap

TEST= lines are for QA people. You don't need to use that line for automated
tests.

[chrishtr, 2015-06-24 17:52:53]

https://codereview.chromium.org/1199343004/diff/1/cc/base/list_container_unit...
File cc/base/list_container_unittest.cc (right):

https://codereview.chromium.org/1199343004/diff/1/cc/base/list_container_unit...
cc/base/list_container_unittest.cc:966: list_1.front()->get_value());
Why not check back() also?

[danakj, 2015-06-24 17:53:11]

LGTM

https://codereview.chromium.org/1199343004/diff/1/cc/base/list_container_unit...
File cc/base/list_container_unittest.cc (right):

https://codereview.chromium.org/1199343004/diff/1/cc/base/list_container_unit...
cc/base/list_container_unittest.cc:884: EXPECT_EQ(2u, list_1.size());  // One
direct allocation, one AppendByMoving.
teehee

https://codereview.chromium.org/1199343004/diff/1/cc/base/list_container_unit...
cc/base/list_container_unittest.cc:983: list_2.back()->get_value());
no need to check back here, since the size is 1 (verified below)

[pdr., 2015-06-24 17:57:01]

On 2015/06/24 at 17:53:11, danakj wrote:
> LGTM
> 
>
https://codereview.chromium.org/1199343004/diff/1/cc/base/list_container_unit...
> File cc/base/list_container_unittest.cc (right):
> 
>
https://codereview.chromium.org/1199343004/diff/1/cc/base/list_container_unit...
> cc/base/list_container_unittest.cc:884: EXPECT_EQ(2u, list_1.size());  // One
direct allocation, one AppendByMoving.
> teehee
> 
>
https://codereview.chromium.org/1199343004/diff/1/cc/base/list_container_unit...
> cc/base/list_container_unittest.cc:983: list_2.back()->get_value());
> no need to check back here, since the size is 1 (verified below)

Thanks for the review. Fixed.

Off to the CQ

[pdr., 2015-06-24 17:57:05]

The CQ bit was checked by pdr@chromium.org

[pdr., 2015-06-24 17:57:05]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1199343004/#ps20001
(title: "Remove extra expect_eq")

[commit-bot: I haz the power, 2015-06-24 17:58:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1199343004/20001

[pdr., 2015-06-24 18:13:20]

The CQ bit was unchecked by pdr@chromium.org

[pdr., 2015-06-24 18:25:44]

A Blink reviewer had trouble understanding the blink version of this patch so
I've updated this test again. I've reordered the equal checks and changed the
list to have a magic 2 and a magic 3 instead of two magic 2's.

@danakj, LGTY?

[danakj, 2015-06-24 18:26:48]

Yup I like it LGTM

[pdr., 2015-06-24 18:27:01]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2015-06-24 18:29:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1199343004/40001

[commit-bot: I haz the power, 2015-06-24 19:40:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-24 19:41:21]

Patchset 3 (id:??) landed as
https://crrev.com/d012546071380244dcadedbd4dc1eccaab004d00
Cr-Commit-Position: refs/heads/master@{#335977}