Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 1199343003: Revert of Remove hotword installation code at compile time if hotwording disabled. (Closed)

Created:
5 years, 6 months ago by Matt Giuca
Modified:
5 years, 6 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Anand Mistry (off Chromium), chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove hotword installation code at compile time if hotwording disabled. (patchset #1 id:1 of https://codereview.chromium.org/1201163002/) Reason for revert: This CL added a compile-time check for ENABLE_HOTWORDING in a file where ENABLE_HOTWORDING is never defined, thus the hotword shared module would never be downloaded. Original issue's description: > Remove hotword installation code at compile time if hotwording disabled. > > If enable_hotwording is false, the code to download/install the hotword > shared module is compiled out. > > (This should not change behaviour; it was already disabled at run-time, > this just removes the installation code from the build.) > > BUG=491435 > > Committed: https://crrev.com/a38832be9fef269ae1f3a191a9b69432aaf680c4 > Cr-Commit-Position: refs/heads/master@{#335843} TBR=benwells@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=491435 Committed: https://crrev.com/1d40cc1e1c6dc12d350bf0da668f2ddcac4f5976 Cr-Commit-Position: refs/heads/master@{#335869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/extensions/external_component_loader.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Matt Giuca
Created Revert of Remove hotword installation code at compile time if hotwording disabled.
5 years, 6 months ago (2015-06-24 03:53:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199343003/1
5 years, 6 months ago (2015-06-24 03:54:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-24 03:55:08 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 03:55:56 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d40cc1e1c6dc12d350bf0da668f2ddcac4f5976
Cr-Commit-Position: refs/heads/master@{#335869}

Powered by Google App Engine
This is Rietveld 408576698