Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1199253006: Revert of Switch SkJpegCode to libjpeg-turbo (Closed)

Created:
5 years, 6 months ago by mtklein
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Switch SkJpegCode to libjpeg-turbo (patchset #11 id:540001 of https://codereview.chromium.org/1180983002/) Reason for revert: https://uberchromegw.corp.google.com/i/client.skia.compile/builders/Build-Ubuntu-GCC-MipsDSP2-Debug-Android/builds/1136/steps/build%20most/logs/stdio Original issue's description: > Add libjpeg-turbo library (depends on yasm) > Mangle external function names to avoid conflict with libjpeg > Take advantage of direct color conversion (RGBA, BGRA, 565) > Prepare to use jpeg_skip_scanlines (when it is upstreamed) > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/b60c3f8291529303299262dba19b1a896060bd2d TBR=scroggo@google.com,djsollen@google.com,emmaleer@google.com,msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c0bdecb920a957665f66adefd3f3fb865e32e5d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -25267 lines) Patch
M DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M dm/DM.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/codec.gyp View 1 chunk +1 line, -4 lines 0 comments Download
D gyp/libjpeg-turbo.gyp View 1 chunk +0 lines, -305 lines 0 comments Download
D gyp/yasm.gyp View 1 chunk +0 lines, -604 lines 0 comments Download
M src/codec/SkJpegCodec.h View 2 chunks +2 lines, -7 lines 0 comments Download
M src/codec/SkJpegCodec.cpp View 12 chunks +170 lines, -157 lines 0 comments Download
M src/codec/SkJpegDecoderMgr.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/codec/SkJpegDecoderMgr.cpp View 2 chunks +14 lines, -1 line 0 comments Download
M src/codec/SkJpegUtility_codec.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/codec/SkJpegUtility_codec.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/yasm/README.skia View 1 chunk +0 lines, -134 lines 0 comments Download
D third_party/yasm/config/android/Makefile View 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/config/android/config.h View 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/yasm/config/android/libyasm-stdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/config/ios/Makefile View 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/config/ios/config.h View 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/yasm/config/ios/libyasm-stdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/config/linux/Makefile View 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/config/linux/config.h View 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/yasm/config/linux/libyasm-stdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/config/mac/Makefile View 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/config/mac/config.h View 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/yasm/config/mac/libyasm-stdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/config/openbsd/Makefile View 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/config/openbsd/config.h View 1 chunk +0 lines, -165 lines 0 comments Download
D third_party/yasm/config/openbsd/libyasm-stdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/config/win/Makefile View 1 chunk +0 lines, -3822 lines 0 comments Download
D third_party/yasm/config/win/config.h View 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/yasm/config/win/libyasm-stdint.h View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/yasm/config/win/stdint.h View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Switch SkJpegCode to libjpeg-turbo
5 years, 6 months ago (2015-06-24 22:14:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199253006/1
5 years, 6 months ago (2015-06-24 22:14:28 UTC) #2
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 22:14:51 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c0bdecb920a957665f66adefd3f3fb865e32e5d0

Powered by Google App Engine
This is Rietveld 408576698