Source/modules/serviceworkers/NavigatorServiceWorker.h - Issue 1199183002: Throw a SecurityError when navigator.serviceWorker is accessed in a sandboxed iframe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/NavigatorServiceWorker.h

Issue 1199183002: Throw a SecurityError when navigator.serviceWorker is accessed in a sandboxed iframe. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: use ASSERT_NO_EXCEPTION Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/chromium/sandboxed-iframe-navigator-serviceworker.html ('k') | Source/modules/serviceworkers/NavigatorServiceWorker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/NavigatorServiceWorker.h

diff --git a/Source/modules/serviceworkers/NavigatorServiceWorker.h b/Source/modules/serviceworkers/NavigatorServiceWorker.h

index dfe55f946e4578e12773917516916039052cea0a..05124a7faa213bc617c11c831147f7cecfa330a9 100644

--- a/Source/modules/serviceworkers/NavigatorServiceWorker.h

+++ b/Source/modules/serviceworkers/NavigatorServiceWorker.h

@@ -13,6 +13,7 @@

namespace blink {

class Document;

+class ExceptionState;

class Navigator;

class ServiceWorkerContainer;

@@ -25,13 +26,13 @@ public:

virtual ~NavigatorServiceWorker();

- static ServiceWorkerContainer* serviceWorker(Navigator&);

+ static ServiceWorkerContainer* serviceWorker(Navigator&, ExceptionState&);

DECLARE_VIRTUAL_TRACE();

private:

explicit NavigatorServiceWorker(Navigator&);

- ServiceWorkerContainer* serviceWorker();

+ ServiceWorkerContainer* serviceWorker(ExceptionState&);

static const char* supplementName();