Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: tests/compiler/dart2js/mirrors_metadata_test.dart

Issue 119913002: Align source mirrors with runtime mirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments + small fix. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/mirrors_lookup_test.dart ('k') | tests/compiler/dart2js/mirrors_mixin_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/mirrors_metadata_test.dart
diff --git a/tests/compiler/dart2js/mirrors_metadata_test.dart b/tests/compiler/dart2js/mirrors_metadata_test.dart
index 66c2e416ae070377745131e7860bf38d3671344c..c4309970c888366f9feabbbe35f0ab432fa8873b 100644
--- a/tests/compiler/dart2js/mirrors_metadata_test.dart
+++ b/tests/compiler/dart2js/mirrors_metadata_test.dart
@@ -11,12 +11,12 @@ void validateDeclarationComment(String code,
String text,
String trimmedText,
bool isDocComment,
- List<String> declarationNames) {
+ List<Symbol> declarationNames) {
asyncTest(() => createMirrorSystem(code).then((mirrors) {
LibraryMirror library = mirrors.libraries[SOURCE_URI];
Expect.isNotNull(library);
- for (String declarationName in declarationNames) {
- DeclarationMirror declaration = library.members[declarationName];
+ for (Symbol declarationName in declarationNames) {
+ DeclarationMirror declaration = library.declarations[declarationName];
Expect.isNotNull(declaration);
List<InstanceMirror> metadata = declaration.metadata;
Expect.isNotNull(metadata);
@@ -30,7 +30,7 @@ void validateDeclarationComment(String code,
}));
}
-void testDeclarationComment(String declaration, List<String> declarationNames) {
+void testDeclarationComment(String declaration, List<Symbol> declarationNames) {
String text = 'Single line comment';
String comment = '// $text';
String code = '$comment\n$declaration';
@@ -51,18 +51,18 @@ void testDeclarationComment(String declaration, List<String> declarationNames) {
}
void main() {
- testDeclarationComment('var field;', ['field']);
- testDeclarationComment('int field;', ['field']);
- testDeclarationComment('int field = 0;', ['field']);
- testDeclarationComment('int field1, field2;', ['field1', 'field2']);
- testDeclarationComment('final field = 0;', ['field']);
- testDeclarationComment('final int field = 0;', ['field']);
- testDeclarationComment('final field1 = 0, field2 = 0;', ['field1', 'field2']);
+ testDeclarationComment('var field;', [#field]);
+ testDeclarationComment('int field;', [#field]);
+ testDeclarationComment('int field = 0;', [#field]);
+ testDeclarationComment('int field1, field2;', [#field1, #field2]);
+ testDeclarationComment('final field = 0;', [#field]);
+ testDeclarationComment('final int field = 0;', [#field]);
+ testDeclarationComment('final field1 = 0, field2 = 0;', [#field1, #field2]);
testDeclarationComment('final int field1 = 0, field2 = 0;',
- ['field1', 'field2']);
- testDeclarationComment('const field = 0;', ['field']);
- testDeclarationComment('const int field = 0;', ['field']);
- testDeclarationComment('const field1 = 0, field2 = 0;', ['field1', 'field2']);
+ [#field1, #field2]);
+ testDeclarationComment('const field = 0;', [#field]);
+ testDeclarationComment('const int field = 0;', [#field]);
+ testDeclarationComment('const field1 = 0, field2 = 0;', [#field1, #field2]);
testDeclarationComment('const int field1 = 0, field2 = 0;',
- ['field1', 'field2']);
+ [#field1, #field2]);
}
« no previous file with comments | « tests/compiler/dart2js/mirrors_lookup_test.dart ('k') | tests/compiler/dart2js/mirrors_mixin_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698