Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: sdk/lib/_internal/compiler/implementation/dart_types.dart

Issue 119913002: Align source mirrors with runtime mirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments + small fix. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/pkg.status ('k') | sdk/lib/_internal/compiler/implementation/mirrors/analyze.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/dart_types.dart
diff --git a/sdk/lib/_internal/compiler/implementation/dart_types.dart b/sdk/lib/_internal/compiler/implementation/dart_types.dart
index a61dac85ba9cb75a13d19484ff5b9490eb671f9f..90e4be565b62dba96806fefb10bf30bd895f70f8 100644
--- a/sdk/lib/_internal/compiler/implementation/dart_types.dart
+++ b/sdk/lib/_internal/compiler/implementation/dart_types.dart
@@ -363,7 +363,7 @@ abstract class GenericType extends DartType {
TypeDeclarationElement get element;
/// Creates a new instance of this type using the provided type arguments.
- GenericType _createType(Link<DartType> newTypeArguments);
+ GenericType createInstantiation(Link<DartType> newTypeArguments);
DartType subst(Link<DartType> arguments, Link<DartType> parameters) {
if (typeArguments.isEmpty) {
@@ -379,7 +379,7 @@ abstract class GenericType extends DartType {
Types.substTypes(typeArguments, arguments, parameters);
if (!identical(typeArguments, newTypeArguments)) {
// Create a new type only if necessary.
- return _createType(newTypeArguments);
+ return createInstantiation(newTypeArguments);
}
return this;
}
@@ -465,7 +465,7 @@ class InterfaceType extends GenericType {
String get name => element.name;
- InterfaceType _createType(Link<DartType> newTypeArguments) {
+ InterfaceType createInstantiation(Link<DartType> newTypeArguments) {
return new InterfaceType(element, newTypeArguments);
}
@@ -798,7 +798,7 @@ class TypedefType extends GenericType {
[Link<DartType> typeArguments = const Link<DartType>()])
: super(typeArguments);
- TypedefType _createType(Link<DartType> newTypeArguments) {
+ TypedefType createInstantiation(Link<DartType> newTypeArguments) {
return new TypedefType(element, newTypeArguments);
}
@@ -1717,7 +1717,7 @@ class MoreSpecificSubtypeVisitor extends DartTypeVisitor<bool, DartType> {
element.typeVariables.forEach((TypeVariableType typeVariable) {
typeArguments.addLast(constraintMap[typeVariable]);
});
- return element.thisType._createType(typeArguments.toLink());
+ return element.thisType.createInstantiation(typeArguments.toLink());
}
return null;
}
« no previous file with comments | « pkg/pkg.status ('k') | sdk/lib/_internal/compiler/implementation/mirrors/analyze.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698