Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 1199113003: Re-ship Harmony Array/TypedArray methods (Closed)

Created:
4 years, 3 months ago by Dan Ehrenberg
Modified:
4 years, 3 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-ship Harmony Array/TypedArray methods Turning the --harmony-array flag on has been delayed behind unrelated test failures. Now that those tests are disabled, land the changes. This patch fixes WebKit tests based on the new change. R=adamk LOG=Y BUG=v8:3578 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/325fbd0e243f6d43c977452651cf4be9a0dad727 Cr-Commit-Position: refs/heads/master@{#29209}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.status View 1 chunk +3 lines, -0 lines 0 comments Download
M test/webkit/fast/js/Object-getOwnPropertyNames.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Dan Ehrenberg
4 years, 3 months ago (2015-06-22 22:54:43 UTC) #1
adamk
lgtm
4 years, 3 months ago (2015-06-22 22:55:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199113003/1
4 years, 3 months ago (2015-06-22 22:56:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2015-06-23 00:41:56 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/325fbd0e243f6d43c977452651cf4be9a0dad727 Cr-Commit-Position: refs/heads/master@{#29209}
4 years, 3 months ago (2015-06-23 00:42:08 UTC) #6
adamk
4 years, 3 months ago (2015-06-23 02:31:49 UTC) #7
Message was sent while issue was closed.
I see one Mac asan failure, but it looks completely unrelated:

http://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/1799/....

Also, it did not fail the last time this landed. So I'm inclined to keep this in
the tree, hoping it'll pass on the next run.

Powered by Google App Engine
This is Rietveld 408576698