Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11991002: Merge 176800 (Closed)

Created:
7 years, 11 months ago by zel
Modified:
7 years, 11 months ago
Reviewers:
zel
CC:
chromium-reviews, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Merge 176800 > OAuth2 sign-in flow for ChromeOS. > > Refactored all OAuth1/2 code out of LoginUtils into OAuthLoginManager class. > > Created OAuth2-based specialization of OAuthLoginManager (behind --force-oauth2 switch). This new class uses OAuth2 refresh tokens as a base token from which all others are minted - incl. GAIA credentials and session cookies. > > BUG=166192, 169999 > TEST=existing unit, browser tests, additional manual testing > TBR=sky > > Review URL: https://codereview.chromium.org/11649055 TBR=zelidrag@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177316

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -781 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/cros/cert_library.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_performer.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/login_performer.cc View 4 chunks +14 lines, -64 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.h View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 17 chunks +47 lines, -284 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/mock_login_utils.h View 2 chunks +2 lines, -5 lines 0 comments Download
A + chrome/browser/chromeos/login/oauth1_login_manager.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/login/oauth1_login_manager.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/login/oauth1_login_verifier.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/login/oauth1_login_verifier.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/chromeos/login/oauth1_token_fetcher.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/oauth1_token_fetcher.cc View 4 chunks +11 lines, -14 lines 0 comments Download
A + chrome/browser/chromeos/login/oauth2_login_manager.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/login/oauth2_login_manager.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/login/oauth2_login_verifier.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/login/oauth2_login_verifier.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/login/oauth2_policy_fetcher.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/login/oauth2_policy_fetcher.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/login/oauth2_token_fetcher.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/login/oauth2_token_fetcher.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/login/oauth_login_manager.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/login/oauth_login_manager.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/chromeos/login/oauth_login_verifier.h View 1 chunk +0 lines, -106 lines 0 comments Download
D chrome/browser/chromeos/login/oauth_login_verifier.cc View 1 chunk +0 lines, -206 lines 0 comments Download
M chrome/browser/chromeos/login/online_attempt.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/parallel_authenticator.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/policy_oauth_fetcher.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/policy_oauth_fetcher.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/profile_auth_data.h View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/profile_auth_data.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/test_login_utils.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/test_login_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/user.h View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 2 chunks +13 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 chunk +9 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/login/user_pod_row.js View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/signin/signin_manager.cc View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/signin/token_service.h View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/signin/token_service.cc View 4 chunks +20 lines, -6 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +14 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.h View 4 chunks +20 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 7 chunks +24 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
zel
7 years, 11 months ago (2013-01-17 02:23:46 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698