Issue 1199063002: Fix mojodb to use the new sky_server API also.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1199063002: Fix mojodb to use the new sky_server API also. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
ppi, eseidel

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix mojodb to use the new sky_server API also. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/88526f395c44745c168ab6dd06be8f3168ecdbd3

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -2 lines)			Patch
	M	mojo/tools/mojodb	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	sky/HACKING.md	View		1 chunk	+19 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

eseidel

lgtm https://codereview.chromium.org/1199063002/diff/1/sky/HACKING.md File sky/HACKING.md (right): https://codereview.chromium.org/1199063002/diff/1/sky/HACKING.md#newcode75 sky/HACKING.md:75: mojodb start --gdb out/Debug app.dart These are soon ...

5 years, 6 months ago (2015-06-22 21:28:18 UTC) #2

Hixie

5 years, 6 months ago (2015-06-22 21:28:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
88526f395c44745c168ab6dd06be8f3168ecdbd3 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages