Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 1199053011: Add mjsunit tests for optimization of float min/max. (Closed)

Created:
5 years, 6 months ago by titzer
Modified:
5 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add mjsunit tests for optimization of float min/max. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/2c979b96f1b4389157ec1060f12a44e07ac34da6 Cr-Commit-Position: refs/heads/master@{#29239}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -0 lines) Patch
A test/mjsunit/compiler/optimize_max.js View 1 1 chunk +69 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/optimize_min.js View 1 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
5 years, 6 months ago (2015-06-23 16:37:16 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/1199053011/diff/1/test/mjsunit/compiler/optimize_max.js File test/mjsunit/compiler/optimize_max.js (right): https://codereview.chromium.org/1199053011/diff/1/test/mjsunit/compiler/optimize_max.js#newcode5 test/mjsunit/compiler/optimize_max.js:5: var DOUBLE_ZERO = 1.0 - 1.0; As discussed ...
5 years, 6 months ago (2015-06-23 16:56:25 UTC) #2
titzer
On 2015/06/23 16:56:25, Michael Starzinger wrote: > LGTM. > > https://codereview.chromium.org/1199053011/diff/1/test/mjsunit/compiler/optimize_max.js > File test/mjsunit/compiler/optimize_max.js (right): ...
5 years, 6 months ago (2015-06-23 17:00:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199053011/20001
5 years, 6 months ago (2015-06-23 17:01:00 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-23 17:26:23 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 17:26:33 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c979b96f1b4389157ec1060f12a44e07ac34da6
Cr-Commit-Position: refs/heads/master@{#29239}

Powered by Google App Engine
This is Rietveld 408576698