Issue 1199053002: Add an informative comment on regress-1132 ASAN suppression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1199053002: Add an informative comment on regress-1132 ASAN suppression (Closed)

Created:
5 years, 6 months ago by adamk

Modified:
5 years, 6 months ago

Reviewers:
arv (Not doing code reviews)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Add an informative comment on regress-1132 ASAN suppression TBR=arv@chromium.org LOG=n Committed: https://chromium.googlesource.com/v8/v8/+/1c575e917a8f32ed516ed03459659755a35f1262

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	test/mjsunit/mjsunit.status	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adamk

Committed patchset #1 (id:1) manually as 1c575e917a8f32ed516ed03459659755a35f1262 (presubmit successful).

5 years, 6 months ago (2015-06-22 21:06:21 UTC) #1

arv (Not doing code reviews)

LGTM A url would have been better than just a bug number.

5 years, 6 months ago (2015-06-22 21:26:46 UTC) #2

adamk

5 years, 6 months ago (2015-06-22 21:29:25 UTC) #3

Message was sent while issue was closed.

On 2015/06/22 21:26:46, arv wrote:
> LGTM
> 
> A url would have been better than just a bug number.

I was going for consistency with the file, but clearly that's not great, sorry.

Expand Messages | Collapse Messages