Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1199013002: [Test262-es6] Update to use FAIL_SLOPPY everywhere (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Test262-es6] Update to use FAIL_SLOPPY everywhere Also reordered related test BUG=N LOG=N R=adamk, littledan Committed: https://crrev.com/7539f322eed1e9d8dd9d857eeba415949584d7cc Cr-Commit-Position: refs/heads/master@{#29200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -93 lines) Patch
M test/test262-es6/test262-es6.status View 12 chunks +209 lines, -91 lines 0 comments Download
M tools/testrunner/local/statusfile.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
arv (Not doing code reviews)
PTAL I had to expand the wildcards since now the outcome is enforced.
5 years, 6 months ago (2015-06-22 16:52:15 UTC) #1
arv (Not doing code reviews)
PTAL I had to expand the wildcards since now the outcome is enforced.
5 years, 6 months ago (2015-06-22 16:52:17 UTC) #2
Dan Ehrenberg
lgtm
5 years, 6 months ago (2015-06-22 18:06:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199013002/1
5 years, 6 months ago (2015-06-22 18:16:27 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-22 18:16:29 UTC) #7
adamk
lgtm
5 years, 6 months ago (2015-06-22 18:18:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199013002/1
5 years, 6 months ago (2015-06-22 18:18:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-22 18:53:32 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 18:53:53 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7539f322eed1e9d8dd9d857eeba415949584d7cc
Cr-Commit-Position: refs/heads/master@{#29200}

Powered by Google App Engine
This is Rietveld 408576698