Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1198993009: [turbofan] NaN is never truish. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
titzer, Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] NaN is never truish. BUG=v8:4207 LOG=y R=jkummerow@chromium.org Committed: https://crrev.com/78e9a2dff20f9f16c69271acfd2d348cd78df816 Cr-Commit-Position: refs/heads/master@{#29230}

Patch Set 1 #

Total comments: 2

Patch Set 2 : REBASE. Test for &&. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/compiler/regress-4207.js View 1 1 chunk +7 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-23 11:35:00 UTC) #1
Benedikt Meurer
Hey Jakob, Trivial fix for the NaN truish issue. Please take a look. Thanks, Benedikt
5 years, 6 months ago (2015-06-23 11:35:28 UTC) #2
titzer
https://codereview.chromium.org/1198993009/diff/1/test/mjsunit/compiler/regress-4207.js File test/mjsunit/compiler/regress-4207.js (right): https://codereview.chromium.org/1198993009/diff/1/test/mjsunit/compiler/regress-4207.js#newcode7 test/mjsunit/compiler/regress-4207.js:7: function foo() { return 0/0 || 1; } What ...
5 years, 6 months ago (2015-06-23 11:41:27 UTC) #4
Benedikt Meurer
https://codereview.chromium.org/1198993009/diff/1/test/mjsunit/compiler/regress-4207.js File test/mjsunit/compiler/regress-4207.js (right): https://codereview.chromium.org/1198993009/diff/1/test/mjsunit/compiler/regress-4207.js#newcode7 test/mjsunit/compiler/regress-4207.js:7: function foo() { return 0/0 || 1; } On ...
5 years, 6 months ago (2015-06-23 11:58:53 UTC) #5
titzer
lgtm
5 years, 6 months ago (2015-06-23 12:02:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198993009/20001
5 years, 6 months ago (2015-06-23 12:03:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-23 12:24:54 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 12:25:01 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/78e9a2dff20f9f16c69271acfd2d348cd78df816
Cr-Commit-Position: refs/heads/master@{#29230}

Powered by Google App Engine
This is Rietveld 408576698