Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 1198993008: Fix regexp perf: Only increase array size if needed (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix regexp perf: Only increase array size if needed BUG=chromium:503457 LOG=n Committed: https://crrev.com/17b26fd2a53d9d65f07a96c80d6f449e7f4cbd3e Cr-Commit-Position: refs/heads/master@{#29228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/jsregexp.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-23 10:51:58 UTC) #2
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-23 11:10:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198993008/1
5 years, 6 months ago (2015-06-23 11:14:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-23 11:41:31 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 11:41:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17b26fd2a53d9d65f07a96c80d6f449e7f4cbd3e
Cr-Commit-Position: refs/heads/master@{#29228}

Powered by Google App Engine
This is Rietveld 408576698