Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: components/bookmarks/test/test_bookmark_client.h

Issue 1198963014: Change ownership of BookmarkClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cleanup_managed_and_supervised_nodes
Patch Set: Rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/test/test_bookmark_client.h
diff --git a/components/bookmarks/test/test_bookmark_client.h b/components/bookmarks/test/test_bookmark_client.h
index 11a1a2cee5e997985e7dadcad3e80a39cf715477..6618ab445506efacc240113be79b2e90999aa0b5 100644
--- a/components/bookmarks/test/test_bookmark_client.h
+++ b/components/bookmarks/test/test_bookmark_client.h
@@ -14,16 +14,16 @@ class BookmarkModel;
class TestBookmarkClient : public BookmarkClient {
public:
- TestBookmarkClient();
- ~TestBookmarkClient() override;
-
- // Create a BookmarkModel using this object as its client. The returned
- // BookmarkModel* is owned by the caller.
- scoped_ptr<BookmarkModel> CreateModel();
+ // Creates a BookmarkModel with a TestBookmarkClient initialized with
+ // |extra_nodes| and return the TestBookmarkClient via |client| if non-null.
+ static scoped_ptr<BookmarkModel> CreateModel(
+ BookmarkPermanentNodeList extra_nodes,
+ TestBookmarkClient** client,
+ bool no_load);
- // Sets the list of extra nodes to be returned by the next call to
- // CreateModel() or GetLoadExtraNodesCallback().
- void SetExtraNodesToLoad(BookmarkPermanentNodeList extra_nodes);
+ // Helper for CreateModel passing an empty BookmarkPermanentNodeList.
+ static scoped_ptr<BookmarkModel> CreateModel(TestBookmarkClient** client);
+ static scoped_ptr<BookmarkModel> CreateModel();
// Returns the current extra_nodes, set via SetExtraNodesToLoad().
const std::vector<BookmarkPermanentNode*>& extra_nodes() {
@@ -37,7 +37,24 @@ class TestBookmarkClient : public BookmarkClient {
bool IsAnExtraNode(const BookmarkNode* node);
private:
+ TestBookmarkClient();
+ ~TestBookmarkClient() override;
+
+ // Sets the list of extra nodes to be returned by the next call to
+ // CreateModel() or GetLoadExtraNodesCallback().
+ void SetExtraNodesToLoad(BookmarkPermanentNodeList extra_nodes);
+
// BookmarkClient:
+ void Init(BookmarkModel* bookmark_model) override;
+ base::CancelableTaskTracker::TaskId GetFaviconImageForPageURL(
+ const GURL& page_url,
+ favicon_base::IconType type,
+ const favicon_base::FaviconImageCallback& callback,
+ base::CancelableTaskTracker* tracker) override;
+ bool SupportsTypedCountForNodes() override;
+ void GetTypedCountForNodes(
+ const NodeSet& nodes,
+ NodeTypedCountPairs* node_typed_count_pairs) override;
void RecordAction(const base::UserMetricsAction& action) override;
LoadExtraCallback GetLoadExtraNodesCallback(
scoped_ptr<BookmarkPermanentNode> managed_node,
« no previous file with comments | « components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc ('k') | components/bookmarks/test/test_bookmark_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698