Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1198963003: [NOCOMMIT] Apply cl/1194003004 on cl/1124153003 PS 10 (Closed)

Created:
5 years, 6 months ago by peria
Modified:
5 years, 5 months ago
Reviewers:
CC:
blink-reviews, tyoshino+watch_chromium.org, arv+blink, vivekg, sof, eae+blinkwatch, Yoav Weiss, blink-reviews-dom_chromium.org, dglazkov+blink, vivekg_samsung, gavinp+loader_chromium.org, Inactive, Nate Chapin, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Apply http://crrev.com/1194003004 on http://crrev.com/1124153003 PS 10, and call m_fetcher.clear() in DocumentLoader.detachFromFrame() and Document.detach(). BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -223 lines) Patch
M Source/core/dom/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 3 chunks +4 lines, -2 lines 0 comments Download
M Source/core/fetch/CachingCorrectnessTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/fetch/FetchContext.h View 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/fetch/FetchContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ImageResourceTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/fetch/MemoryCache.h View 8 chunks +17 lines, -19 lines 0 comments Download
M Source/core/fetch/MemoryCache.cpp View 8 chunks +16 lines, -33 lines 0 comments Download
M Source/core/fetch/MemoryCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/Resource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.h View 5 chunks +10 lines, -10 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 3 chunks +1 line, -9 lines 0 comments Download
M Source/core/fetch/ResourceFetcherTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ResourceLoader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/fetch/ResourceLoader.cpp View 9 chunks +3 lines, -21 lines 0 comments Download
A Source/core/fetch/ResourceLoaderHost.h View 1 chunk +86 lines, -0 lines 0 comments Download
M Source/core/fetch/ResourceLoaderSet.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/fetch/ResourceLoaderSet.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M Source/core/frame/ImageBitmapTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/LocalDOMWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.h View 5 chunks +15 lines, -12 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 11 chunks +33 lines, -19 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/EmptyClients.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameFetchContext.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/loader/FrameFetchContextTest.cpp View 5 chunks +18 lines, -7 lines 0 comments Download
M Source/core/loader/FrameLoader.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 3 chunks +5 lines, -2 lines 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/appcache/ApplicationCache.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/loader/appcache/ApplicationCache.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/appcache/ApplicationCacheHost.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/loader/appcache/ApplicationCacheHost.cpp View 6 chunks +32 lines, -32 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebDataSourceImpl.h View 3 chunks +5 lines, -1 line 0 comments Download
M Source/web/WebDataSourceImpl.cpp View 2 chunks +18 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698