Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1198923002: [turbofan] Run DeadCodeElimination as part of the generic lowering phase. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Run DeadCodeElimination as part of the generic lowering phase. This way we don't need the separate late control reduction pass over the graph, plus we can also reduce dead code recognized by generic lowering. R=jarin@chromium.org Committed: https://crrev.com/94a0bc8e90830dd474d9a7405c2db66cfde30df9 Cr-Commit-Position: refs/heads/master@{#29174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -23 lines) Patch
M src/compiler/pipeline.cc View 3 chunks +13 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-22 06:29:12 UTC) #1
Benedikt Meurer
Hey Jaro, First steps towards running DeadCodeElimination as part of the normal reductions. Please take ...
5 years, 6 months ago (2015-06-22 06:33:17 UTC) #2
Jarin
lgtm
5 years, 6 months ago (2015-06-22 06:52:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198923002/1
5 years, 6 months ago (2015-06-22 06:52:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-22 07:04:09 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 07:04:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94a0bc8e90830dd474d9a7405c2db66cfde30df9
Cr-Commit-Position: refs/heads/master@{#29174}

Powered by Google App Engine
This is Rietveld 408576698