Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1857)

Unified Diff: Source/core/timing/PerformanceUserTiming.h

Issue 1198863006: First version of PerformanceObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Code review comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/timing/PerformanceResourceTiming.h ('k') | Source/core/timing/PerformanceUserTiming.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/timing/PerformanceUserTiming.h
diff --git a/Source/core/timing/PerformanceUserTiming.h b/Source/core/timing/PerformanceUserTiming.h
index af68d36b5620f423409e86609544aae7f6693ebc..fbc4814061195def7cc859d6b490a472841bc77d 100644
--- a/Source/core/timing/PerformanceUserTiming.h
+++ b/Source/core/timing/PerformanceUserTiming.h
@@ -41,15 +41,15 @@ using PerformanceEntryMap = HeapHashMap<String, PerformanceEntryVector>;
class UserTiming final : public GarbageCollected<UserTiming> {
public:
- static UserTiming* create(PerformanceBase* performance)
+ static UserTiming* create(PerformanceBase& performance)
{
return new UserTiming(performance);
}
- void mark(const String& markName, ExceptionState&);
+ PerformanceEntry* mark(const String& markName, ExceptionState&);
void clearMarks(const String& markName);
- void measure(const String& measureName, const String& startMark, const String& endMark, ExceptionState&);
+ PerformanceEntry* measure(const String& measureName, const String& startMark, const String& endMark, ExceptionState&);
void clearMeasures(const String& measureName);
PerformanceEntryVector getMarks() const;
@@ -61,7 +61,7 @@ public:
DECLARE_TRACE();
private:
- explicit UserTiming(PerformanceBase*);
+ explicit UserTiming(PerformanceBase&);
double findExistingMarkStartTime(const String& markName, ExceptionState&);
« no previous file with comments | « Source/core/timing/PerformanceResourceTiming.h ('k') | Source/core/timing/PerformanceUserTiming.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698