LayoutTests/inspector/sources/debugger-async/async-callstack-performance-observer.html - Issue 1198863006: First version of PerformanceObserver

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/inspector/sources/debugger-async/async-callstack-performance-observer.html

Issue 1198863006: First version of PerformanceObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add LayoutTest Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt ('k') | LayoutTests/inspector/sources/debugger-async/async-callstack-performance-observer-expected.txt » ('j') | Source/core/inspector/InspectorInstrumentation.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../../http/tests/inspector/inspector-test.js"></script>

	4 <script src="../../../http/tests/inspector/debugger-test.js"></script>

	5 <script>

	6

	7 var observer = new PerformanceObserver(performanceCallback);

	8

	9 function performanceCallback(performanceEntryList)

	10 {

	11 debugger;

	12 }

	13

	14 function testFunction()

	15 {

	16 setTimeout(timeout1, 0);

	17 var config = { entryTypes: ['mark', 'measure']};

	18 observer.observe(config);

	19 }

	20

	21 function timeout1()

	22 {

	23 setTimeout(timeout2, 0);

	24 window.performance.mark('mark_1');

	25 }

	26

	27 function timeout2()

	28 {

	29 setTimeout(timeout3, 0);

	30 window.performance.mark('mark_2');

	31 }

	32

	33 function timeout3()
	yurys 2015/08/26 19:17:05 what's the value for the user of async call stacks what's the value for the user of async call stacks for PeformanceObserver callback? In this particular scenario we already have async stacks for setTimeout which should be enough for debugging purposes. Also it seems unusual to have debugger instrumentation on the profiling stuff. I'd rather not add async call stack support for PerformanceObserver at all unless there is a strong case that we need it. MikeB 2015/08/27 18:02:49 Done. Show quoted text On 2015/08/26 19:17:05, yurys wrote: > what's the value for the user of async call stacks for PeformanceObserver > callback? In this particular scenario we already have async stacks for > setTimeout which should be enough for debugging purposes. Also it seems unusual > to have debugger instrumentation on the profiling stuff. I'd rather not add > async call stack support for PerformanceObserver at all unless there is a strong > case that we need it. Done.
	34 {

	35 window.performance.measure('measure_1', 'mark_1', 'mark_2');

	36 }

	37

	38 var test = function()

	39 {

	40 var totalDebuggerStatements = 3;

	41 var maxAsyncCallStackDepth = 5;

	42 InspectorTest.runAsyncCallStacksTest(totalDebuggerStatements, maxAsyncCallSt ackDepth);

	43 }

	44

	45 </script>

	46 </head>

	47

	48 <body onload="runTest()">

	49 <p>

	50 Tests asynchronous call stacks for PerformanceObserver.

	51 </p>

	52 </body>

	53 </html>

OLD	NEW