First version of PerformanceObserver

Source/core/timing/PerformanceObserverEntryList.cpp

+/*
+ * Copyright (C) 2015 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ *     * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+
+#include "core/timing/PerformanceObserverEntryList.h"
+
+#include "core/timing/PerformanceEntry.h"
+
+#include "wtf/StdLibExtras.h"
+
+namespace blink {
+
+PerformanceObserverEntryList::PerformanceObserverEntryList(const PerformanceEntryVector& entryVector)
+    : m_performanceEntries(entryVector)
+{
+}
+
+PerformanceObserverEntryList::~PerformanceObserverEntryList()
+{
+}
+
+
+PerformanceEntryVector PerformanceObserverEntryList::getEntries() const
+{
+    PerformanceEntryVector entries;
+
+    entries.appendVector(m_performanceEntries);
+
+    std::sort(entries.begin(), entries.end(), PerformanceEntry::startTimeCompareLessThan);
+    return entries;
+}
+
+PerformanceEntryVector PerformanceObserverEntryList::getEntriesByType(const String& entryType)
+{
+    PerformanceEntryVector entries;
+
+    for (const auto& entry : m_performanceEntries) {
+        if (entryType.isNull() || equalIgnoringCase(entryType, entry->entryType())) {

[esprehn, 2015/07/18 22:24:16]

This method shouldn't accept null at all, doing getEntriesByType(null) returning
all entries is very weird.

i think you want to convert the entrytype argument to an enum and then compare
that here as well, not compare strings for every entry

[MikeB, 2015/07/20 23:06:50]

Done.

+            entries.append(entry);
+        }
+    }
+
+    std::sort(entries.begin(), entries.end(), PerformanceEntry::startTimeCompareLessThan);
+    return entries;
+}
+
+PerformanceEntryVector PerformanceObserverEntryList::getEntriesByName(const String& name, const String& entryType)
+{
+    PerformanceEntryVector entries;
+
+    for (const auto& entry : m_performanceEntries) {
+        if (entry->name() == name && (entryType.isNull() || equalIgnoringCase(entryType, entry->entryType()))) {

[esprehn, 2015/07/18 22:24:16]

ditto, you and to use AtomicStrings here as well. the name argument should be an
AtomicString and name() on the entries should be as well

[MikeB, 2015/07/20 23:06:50]

Performance and PerformanceEntry use String at the moment, should I update them
to AtomicString too?

+            entries.append(entry);
+        }
+    }
+
+    std::sort(entries.begin(), entries.end(), PerformanceEntry::startTimeCompareLessThan);
+    return entries;
+}
+
+DEFINE_TRACE(PerformanceObserverEntryList)
+{
+    visitor->trace(m_performanceEntries);
+}
+
+} // namespace blink