tools/telemetry/telemetry/benchmark.py - Issue 1198823004: Update perf page_set to use story_set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/benchmark.py

Issue 1198823004: Update perf page_set to use story_set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/benchmark.py

diff --git a/tools/telemetry/telemetry/benchmark.py b/tools/telemetry/telemetry/benchmark.py

index 7f3f1aefb0dc5ed6ac1420da3ca693b912cdfe32..a8cfe5ee0cb59a5a06ba7a0db0226ecf0ba61db1 100644

--- a/tools/telemetry/telemetry/benchmark.py

+++ b/tools/telemetry/telemetry/benchmark.py

@@ -250,8 +250,6 @@ class Benchmark(command_line.Command):

"""

if not hasattr(self, 'page_set'):

raise NotImplementedError('This test has no "page_set" attribute.')

- if not issubclass(self.page_set, page_set.PageSet):

- raise TypeError('"%s" is not a PageSet.' % self.page_set.__name__)

return self.page_set()

def CreateStorySet(self, options):

« no previous file with comments | « tools/perf/replace.sh ('k') | tools/telemetry/telemetry/page/__init__.py » ('j') | no next file with comments »