Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Unified Diff: tools/perf/page_sets/chrome_signin.py

Issue 1198823004: Update perf page_set to use story_set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/blob_workshop.py ('k') | tools/perf/page_sets/five_blank_pages.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/chrome_signin.py
diff --git a/tools/perf/page_sets/chrome_signin.py b/tools/perf/page_sets/chrome_signin.py
index 328bee2ba1e46d1d6c2b06fdbb6302204b547292..8e0014889269064aeab306903b7b734a799a58c8 100644
--- a/tools/perf/page_sets/chrome_signin.py
+++ b/tools/perf/page_sets/chrome_signin.py
@@ -1,11 +1,10 @@
# Copyright 2015 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-from telemetry.page import shared_page_state
-from telemetry.page import page as page_module
-from telemetry.page import page_set as page_set_module
-
from page_sets.login_helpers import chrome_login
+from telemetry import story
+from telemetry.page import page as page_module
+from telemetry.page import shared_page_state
class ChromeSigninPage(page_module.Page):
@@ -16,7 +15,7 @@ class ChromeSigninPage(page_module.Page):
url='chrome://signin-internals',
page_set=page_set,
credentials_path='data/chrome_signin_credentials.json',
- credentials_bucket=page_set_module.INTERNAL_BUCKET,
+ credentials_bucket=story.INTERNAL_BUCKET,
shared_page_state_class=shared_page_state.SharedDesktopPageState)
def RunPageInteractions(self, action_runner):
@@ -26,10 +25,10 @@ class ChromeSigninPage(page_module.Page):
credentials_path=self.credentials_path)
-class ChromeSigninPageSet(page_set_module.PageSet):
+class ChromeSigninPageSet(story.StorySet):
def __init__(self):
super(ChromeSigninPageSet, self).__init__(
archive_data_file='data/chrome_signin_archive.json',
- bucket=page_set_module.INTERNAL_BUCKET)
+ cloud_storage_bucket=story.INTERNAL_BUCKET)
self.AddUserStory(ChromeSigninPage(self))
« no previous file with comments | « tools/perf/page_sets/blob_workshop.py ('k') | tools/perf/page_sets/five_blank_pages.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698