Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 1198693002: Reland "Roll buildtools fa660d47..ecc8e253" (Closed)

Created:
5 years, 6 months ago by Dirk Pranke
Modified:
5 years, 6 months ago
Reviewers:
brettw, agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Roll buildtools fa660d47..ecc8e253" Original issue's description: > Roll buildtools fa660d47..ecc8e253 > > https://chromium.googlesource.com/chromium/buildtools/+log/fa660d47..ecc8e253 > > ecc8e25 Roll GN #330790:#333203 (9d04333f..4e3e57b2) > 46ce8cb Optionally support relative include paths in cpp_checker.py > b983eee Fix the .gitignore rules to complain about linux32 if need be. > > The GN roll contains the following changes to tools/gn: > > https://chromium.googlesource.com/chromium/src.git/+log/9d04333f..4e3e57b2/tools/gn > > 56affab Check for inputs not generated by deps > e903c0f Allow directories for GN data lists. > ff0986f GN: Make file/dir resolving return errors. > b73b2de Add support for module-definition files to gn > 58a1b33 Add base/files/file_tracing.cc to tools/gn/bootstrap/bootstrap.py. > 92acc5e gn: Add a newline to fix a bulleted list in README.md. > 81d969a Fix missing print command in a GN error case. > a9adafe Make GN header checker more lenient about toolchains. > > In addition, the Linux build of GN was the first build with > use_ozone=true use_glib=false in order to not have a runtime The roll was reverted because #335350 introduced a new target in //chrome/android that had some missing deps. This attempt at the roll includes a fix for that. TBR=brettw@chromium.org, agrieve@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_dbg,mac_chromium_gn_rel;tryserver.chromium.win:win8_chromium_gn_dbg;tryserver.chromium.linux:linux_chromium_gn_chromeos_dbg Committed: https://crrev.com/55c615dc327046f24354b815e1edc795ed52bccb Cr-Commit-Position: refs/heads/master@{#335412}

Patch Set 1 #

Patch Set 2 : fix android rules for missing dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/rules.gni View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Dirk Pranke
5 years, 6 months ago (2015-06-19 23:52:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198693002/20001
5 years, 6 months ago (2015-06-20 00:01:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_gn_dbg on tryserver.chromium.win (JOB_FAILED, no build URL)
5 years, 6 months ago (2015-06-20 00:05:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198693002/20001
5 years, 6 months ago (2015-06-20 00:08:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-20 01:20:06 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-20 01:21:07 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55c615dc327046f24354b815e1edc795ed52bccb
Cr-Commit-Position: refs/heads/master@{#335412}

Powered by Google App Engine
This is Rietveld 408576698