Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 1198633002: Add a nacl module args file. (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a nacl module args file. This is being added to the nacl directory and the Chrome one needs to match. TBR=bradnelson@chromium.org Committed: https://crrev.com/53e14ad309ecde58d21f261f9a8297a98f7ae4f5 Cr-Commit-Position: refs/heads/master@{#335364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
A + build/module_args/nacl.gni View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
5 years, 6 months ago (2015-06-19 21:39:03 UTC) #1
bradn
lgtm
5 years, 6 months ago (2015-06-19 21:39:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198633002/1
5 years, 6 months ago (2015-06-19 21:40:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-19 22:26:57 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 22:27:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53e14ad309ecde58d21f261f9a8297a98f7ae4f5
Cr-Commit-Position: refs/heads/master@{#335364}

Powered by Google App Engine
This is Rietveld 408576698