Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1519)

Unified Diff: Source/platform/graphics/paint/DrawingDisplayItem.h

Issue 1198583004: Move all drawing display item parameters to the constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix release build Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/platform/graphics/paint/DrawingRecorder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/paint/DrawingDisplayItem.h
diff --git a/Source/platform/graphics/paint/DrawingDisplayItem.h b/Source/platform/graphics/paint/DrawingDisplayItem.h
index 3e2b721d5b64062928c3557cee82b8d5903152bb..8b4b46674c109145df0a46bb5dafe0cb9d1e0305 100644
--- a/Source/platform/graphics/paint/DrawingDisplayItem.h
+++ b/Source/platform/graphics/paint/DrawingDisplayItem.h
@@ -22,19 +22,37 @@ public:
};
#endif
- DrawingDisplayItem(const DisplayItemClientWrapper& client, Type type, PassRefPtr<const SkPicture> picture)
- : DisplayItem(client, type)
- , m_picture(picture && picture->approximateOpCount() ? picture : nullptr)
+ static PassOwnPtr<DrawingDisplayItem> create(const DisplayItemClientWrapper& client
+ , Type type
+ , PassRefPtr<const SkPicture> picture
#if ENABLE(ASSERT)
- , m_underInvalidationCheckingMode(CheckPicture)
+ , UnderInvalidationCheckingMode underInvalidationCheckingMode = CheckPicture
#endif
+ )
{
- ASSERT(isDrawingType(type));
+ return adoptPtr(new DrawingDisplayItem(client
+ , type
+ , picture
+#if ENABLE(ASSERT)
+ , underInvalidationCheckingMode
+#endif
+ ));
}
- static PassOwnPtr<DrawingDisplayItem> create(const DisplayItemClientWrapper& client, Type type, PassRefPtr<const SkPicture> picture)
+ DrawingDisplayItem(const DisplayItemClientWrapper& client
+ , Type type
+ , PassRefPtr<const SkPicture> picture
+#if ENABLE(ASSERT)
+ , UnderInvalidationCheckingMode underInvalidationCheckingMode
+#endif
+ )
+ : DisplayItem(client, type)
+ , m_picture(picture && picture->approximateOpCount() ? picture : nullptr)
{
- return adoptPtr(new DrawingDisplayItem(client, type, picture));
+#if ENABLE(ASSERT)
+ m_underInvalidationCheckingMode = underInvalidationCheckingMode;
+#endif
+ ASSERT(isDrawingType(type));
}
virtual void replay(GraphicsContext&);
@@ -44,7 +62,6 @@ public:
const SkPicture* picture() const { return m_picture.get(); }
#if ENABLE(ASSERT)
- void setUnderInvalidationCheckingMode(UnderInvalidationCheckingMode mode) { m_underInvalidationCheckingMode = mode; }
UnderInvalidationCheckingMode underInvalidationCheckingMode() const { return m_underInvalidationCheckingMode; }
#endif
« no previous file with comments | « no previous file | Source/platform/graphics/paint/DrawingRecorder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698