Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(79)

Issue 1198583004: Move all drawing display item parameters to the constructor (Closed)

Created:
4 years, 10 months ago by pdr.
Modified:
4 years, 10 months ago
Reviewers:
chrishtr
CC:
blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move all drawing display item parameters to the constructor This patch changes DrawingDisplayItem to take a debug parameter through the constructor instead of a setter. No new tests as there should be no change in behavior. BUG=484943 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197512

Patch Set 1 #

Patch Set 2 : Fix release build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -10 lines) Patch
M Source/platform/graphics/paint/DrawingDisplayItem.h View 1 2 chunks +25 lines, -8 lines 0 comments Download
M Source/platform/graphics/paint/DrawingRecorder.cpp View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pdr.
This is the only other display item (the other being ClipDisplayItem) that needs this modification. ...
4 years, 10 months ago (2015-06-19 22:42:14 UTC) #2
chrishtr
lgtm
4 years, 10 months ago (2015-06-19 22:46:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198583004/1
4 years, 10 months ago (2015-06-19 22:46:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59879)
4 years, 10 months ago (2015-06-19 22:54:42 UTC) #7
pdr.
On 2015/06/19 at 22:54:42, commit-bot wrote: > Try jobs failed on following builders: > mac_blink_rel ...
4 years, 10 months ago (2015-06-19 23:02:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198583004/20001
4 years, 10 months ago (2015-06-19 23:03:13 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2015-06-20 00:26:07 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197512

Powered by Google App Engine
This is Rietveld 408576698