Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1381)

Unified Diff: Source/platform/graphics/paint/ClipDisplayItem.cpp

Issue 1198583003: Remove SkRegion::kIntersect_Op parameter from ClipDisplayItems (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/graphics/paint/ClipDisplayItem.h ('k') | Source/platform/graphics/paint/ClipRecorder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/paint/ClipDisplayItem.cpp
diff --git a/Source/platform/graphics/paint/ClipDisplayItem.cpp b/Source/platform/graphics/paint/ClipDisplayItem.cpp
index 26eb7900ec54c0b23c77b90f5e579c9607c4df57..55293b6f755147d2f975a4c9a5b664ba37657860 100644
--- a/Source/platform/graphics/paint/ClipDisplayItem.cpp
+++ b/Source/platform/graphics/paint/ClipDisplayItem.cpp
@@ -15,9 +15,9 @@ namespace blink {
void ClipDisplayItem::replay(GraphicsContext& context)
{
context.save();
- context.clipRect(m_clipRect, NotAntiAliased, m_operation);
+ context.clipRect(m_clipRect, NotAntiAliased, SkRegion::kIntersect_Op);
for (FloatRoundedRect roundedRect : m_roundedRectClips)
- context.clipRoundedRect(roundedRect, m_operation);
+ context.clipRoundedRect(roundedRect, SkRegion::kIntersect_Op);
}
void ClipDisplayItem::appendToWebDisplayItemList(WebDisplayItemList* list) const
@@ -38,7 +38,6 @@ void ClipDisplayItem::appendToWebDisplayItemList(WebDisplayItemList* list) const
skRoundedRect.setRectRadii(m_roundedRectClips[i].rect(), skRadii);
webRoundedRects[i] = skRoundedRect;
}
- // FIXME: needs to include the SkRegion::Op
list->appendClipItem(m_clipRect, webRoundedRects);
}
« no previous file with comments | « Source/platform/graphics/paint/ClipDisplayItem.h ('k') | Source/platform/graphics/paint/ClipRecorder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698