Issue 1198583003: Remove SkRegion::kIntersect_Op parameter from ClipDisplayItems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1198583003: Remove SkRegion::kIntersect_Op parameter from ClipDisplayItems (Closed)

Created:
4 years, 10 months ago by pdr.

Modified:
4 years, 10 months ago

Reviewers:
chrishtr

CC:
blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove SkRegion::kIntersect_Op parameter from ClipDisplayItems This patch removes the operation from clip display items and friends. This parameter was never used. We now use a fixed "SkRegion::kIntersect_Op" operation. BUG=484943 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197505

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -12 lines)			Patch
M	Source/platform/graphics/paint/ClipDisplayItem.h	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	Source/platform/graphics/paint/ClipDisplayItem.cpp	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/platform/graphics/paint/ClipRecorder.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/graphics/paint/ClipRecorder.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198583003/1

4 years, 10 months ago (2015-06-19 21:20:25 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2015-06-19 23:17:39 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197505

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages