Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Issue 119853004: Blink Unicode Bidi implementation does not support L1 rule. (Closed)

Created:
6 years, 11 months ago by igoroliveira
Modified:
6 years, 11 months ago
CC:
blink-reviews, bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+bidiwatch_chromium.org, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Blink bidi code does not have a L1 implementation, all the L1 logic is done by RenderBlockFlow::handleTrailingSpaces in the rendering code. The purpose of this patch is moving the handleTrailingSpaces logic to BidiResolver. [1] http://www.unicode.org/reports/tr9/#L1 BUG=316409 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164557

Patch Set 1 #

Patch Set 2 : Proposed patch v2 #

Patch Set 3 : Proposed patch #

Total comments: 1

Patch Set 4 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -76 lines) Patch
M Source/core/rendering/InlineIterator.h View 1 1 chunk +61 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 3 chunks +1 line, -76 lines 0 comments Download
M Source/platform/text/BidiResolver.h View 1 2 3 8 chunks +55 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
igoroliveira
6 years, 11 months ago (2014-01-04 03:56:44 UTC) #1
leviw_travelin_and_unemployed
Great! Lgtm. https://codereview.chromium.org/119853004/diff/100001/Source/platform/text/BidiResolver.h File Source/platform/text/BidiResolver.h (right): https://codereview.chromium.org/119853004/diff/100001/Source/platform/text/BidiResolver.h#newcode286 Source/platform/text/BidiResolver.h:286: void applyL1Rule(); Can you add a link ...
6 years, 11 months ago (2014-01-06 21:46:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/119853004/150001
6 years, 11 months ago (2014-01-06 23:00:25 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=13493
6 years, 11 months ago (2014-01-06 23:20:43 UTC) #4
eae
LGTM
6 years, 11 months ago (2014-01-06 23:51:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/119853004/150001
6 years, 11 months ago (2014-01-06 23:51:37 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 10:01:46 UTC) #7
Message was sent while issue was closed.
Change committed as 164557

Powered by Google App Engine
This is Rietveld 408576698