[es6] throw TypeError when setting cyclic prototype value

[es6] throw TypeError when setting cyclic prototype value

Object.setPrototypeOf() throws a TypeError if value would create a
cycle. Previously a plain Error was thrown rather than a TypeError.

BUG=v8:4197
R=mike@bocoup.com
LOG=N

Committed: https://crrev.com/1765866b0b378334180a307c8819b0420a702812
Cr-Commit-Position: refs/heads/master@{#29169}

[caitp (gmail), 2015-06-19 16:31:05]

that should do it

[mike4, 2015-06-19 16:43:12]

Nice, clean fix. And so fast! I just had one idea about another
assertion--comment in-line.

https://codereview.chromium.org/1198523002/diff/1/test/mjsunit/harmony/set-pr...
File test/mjsunit/harmony/set-prototype-of.js (right):

https://codereview.chromium.org/1198523002/diff/1/test/mjsunit/harmony/set-pr...
test/mjsunit/harmony/set-prototype-of.js:153: Object.setPrototypeOf(object,
value);
How about a second assertion for `object.__proto__ = value`? At first I thought
this might need to go somewhere else, but it doesn't look like the mjsunit suite
makes any distinction for Annex B functionality.

[caitp (gmail), 2015-06-19 17:05:10]

caitpotter88@gmail.com changed reviewers:
+ arv@chromium.org, rossberg@chromium.org

[caitp (gmail), 2015-06-19 17:05:36]

https://codereview.chromium.org/1198523002/diff/1/test/mjsunit/harmony/set-pr...
File test/mjsunit/harmony/set-prototype-of.js (right):

https://codereview.chromium.org/1198523002/diff/1/test/mjsunit/harmony/set-pr...
test/mjsunit/harmony/set-prototype-of.js:153: Object.setPrototypeOf(object,
value);
On 2015/06/19 16:43:12, mike4 wrote:
> How about a second assertion for `object.__proto__ = value`? At first I
thought
> this might need to go somewhere else, but it doesn't look like the mjsunit
suite
> makes any distinction for Annex B functionality.

Done.

[arv (Not doing code reviews), 2015-06-19 17:12:27]

LGTM

Maybe update the CL description to say that we used to throw an Error and not a
TypeError. When I first read it I thought: "I know we check for cycles already"

https://codereview.chromium.org/1198523002/diff/20001/test/mjsunit/harmony/se...
File test/mjsunit/harmony/set-prototype-of.js (right):

https://codereview.chromium.org/1198523002/diff/20001/test/mjsunit/harmony/se...
test/mjsunit/harmony/set-prototype-of.js:151: var value = objects[i+1];
ws

[caitp (gmail), 2015-06-19 17:21:13]

The CQ bit was checked by caitpotter88@gmail.com

[caitp (gmail), 2015-06-19 17:21:14]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org
Link to the patchset: https://codereview.chromium.org/1198523002/#ps40001
(title: "spaces between operators and operands")

[commit-bot: I haz the power, 2015-06-19 17:21:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1198523002/40001

[caitp (gmail), 2015-06-19 17:35:39]

The CQ bit was checked by caitpotter88@gmail.com

[caitp (gmail), 2015-06-19 17:35:39]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org
Link to the patchset: https://codereview.chromium.org/1198523002/#ps60001
(title: "Fix webkit failure")

[commit-bot: I haz the power, 2015-06-19 17:36:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1198523002/60001

[commit-bot: I haz the power, 2015-06-19 20:09:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-19 20:09:54]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

[caitp (gmail), 2015-06-19 20:11:51]

On 2015/06/19 20:09:54, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_blink_rel on tryserver.blink (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)

blink D: :(

[caitp (gmail), 2015-06-19 22:16:09]

On 2015/06/19 20:11:51, caitp wrote:
> On 2015/06/19 20:09:54, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   linux_blink_rel on tryserver.blink (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/6...)
> 
> blink D: :(

Test expectations adjusted in https://codereview.chromium.org/1192843005/

[caitp (gmail), 2015-06-19 22:16:18]

The CQ bit was checked by caitpotter88@gmail.com

[commit-bot: I haz the power, 2015-06-19 22:16:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1198523002/60001

[commit-bot: I haz the power, 2015-06-19 22:18:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-19 22:18:49]

Patchset 4 (id:??) landed as
https://crrev.com/1765866b0b378334180a307c8819b0420a702812
Cr-Commit-Position: refs/heads/master@{#29169}