Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1198513003: Revert "Adding Chrome-side WebVR interface and Cardboard implementation" (Closed)

Created:
5 years, 6 months ago by bajones
Modified:
5 years, 6 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, ben+mojo_chromium.org, dzhioev+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, asvitkine+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, oshima+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Adding Chrome-side WebVR interface and Cardboard implementation" This reverts commit 4ab52def6d1861a55fd9864b47f56c16e4b423a0. Commit broke Android M bots due to cardboard-java's use of android.util.FloatMath, which was deprecated in API level 22 (see http://developer.android.com/reference/android/util/FloatMath.html) BUG=389343 TBR=tsepez@chromium.org, mpearson@chromium.org, jochen@chromium.org Committed: https://crrev.com/e33731cd7108536b56e18e722af5c9d425c47d55 Cr-Commit-Position: refs/heads/master@{#335349}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1514 lines) Patch
M build/common.gypi View 3 chunks +0 lines, -12 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/features.gni View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
D content/browser/vr/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D content/browser/vr/android/cardboard/cardboard_vr_device.h View 1 chunk +0 lines, -37 lines 0 comments Download
D content/browser/vr/android/cardboard/cardboard_vr_device.cc View 1 chunk +0 lines, -188 lines 0 comments Download
D content/browser/vr/android/cardboard/cardboard_vr_device_provider.h View 1 chunk +0 lines, -33 lines 0 comments Download
D content/browser/vr/android/cardboard/cardboard_vr_device_provider.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D content/browser/vr/test/fake_vr_device.h View 1 chunk +0 lines, -34 lines 0 comments Download
D content/browser/vr/test/fake_vr_device.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D content/browser/vr/test/fake_vr_device_provider.h View 1 chunk +0 lines, -35 lines 0 comments Download
D content/browser/vr/test/fake_vr_device_provider.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D content/browser/vr/vr_device.h View 1 chunk +0 lines, -48 lines 0 comments Download
D content/browser/vr/vr_device.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D content/browser/vr/vr_device_manager.h View 1 chunk +0 lines, -78 lines 0 comments Download
D content/browser/vr/vr_device_manager.cc View 1 chunk +0 lines, -148 lines 0 comments Download
D content/browser/vr/vr_device_manager_unittest.cc View 1 chunk +0 lines, -96 lines 0 comments Download
D content/browser/vr/vr_device_provider.h View 1 chunk +0 lines, -27 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/vr_service.mojom View 1 chunk +0 lines, -73 lines 0 comments Download
M content/content.gyp View 1 chunk +0 lines, -10 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -17 lines 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +0 lines, -11 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/input/CardboardVRDevice.java View 1 chunk +0 lines, -88 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download
M content/renderer/render_frame_impl.h View 3 chunks +0 lines, -10 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +0 lines, -13 lines 0 comments Download
D content/renderer/vr/vr_dispatcher.h View 1 chunk +0 lines, -55 lines 0 comments Download
D content/renderer/vr/vr_dispatcher.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D content/renderer/vr/vr_type_converters.h View 1 chunk +0 lines, -62 lines 0 comments Download
D content/renderer/vr/vr_type_converters.cc View 1 chunk +0 lines, -147 lines 0 comments Download
M mojo/common/weak_binding_set.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/cardboard-java/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198513003/20001
5 years, 6 months ago (2015-06-19 19:11:50 UTC) #2
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-19 21:18:42 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 21:19:37 UTC) #4
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e33731cd7108536b56e18e722af5c9d425c47d55
Cr-Commit-Position: refs/heads/master@{#335349}

Powered by Google App Engine
This is Rietveld 408576698