Issue 119843004: Revert "Revert r19394 - "Revert r18390 - "Roll gyp 1685:1806""" because of broken windows bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119843004: Revert "Revert r19394 - "Revert r18390 - "Roll gyp 1685:1806""" because of broken windows bots. (Closed)

Created:
6 years, 11 months ago by ulan

Modified:
6 years, 11 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Revert r19394 - "Revert r18390 - "Roll gyp 1685:1806""" because of broken windows bots. R=jochen@chromium.org TBR=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18435

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -43 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
D	build/gyp_v8.py	View	1 chunk	+0 lines, -41 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ulan

Committed patchset #1 manually as r18435 (presubmit successful).

6 years, 11 months ago (2014-01-02 10:49:54 UTC) #3

jochen (gone - plz use gerrit)

6 years, 11 months ago (2014-01-02 15:10:45 UTC) #4

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/122063003/ by jochen@chromium.org.

The reason for reverting is: give it another try.

Expand Messages | Collapse Messages