Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: pkg/analysis_server/lib/src/context_manager.dart

Issue 1198423002: gracefully degrade if package map input file cannot be watched (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: rework patch Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/context_manager.dart
diff --git a/pkg/analysis_server/lib/src/context_manager.dart b/pkg/analysis_server/lib/src/context_manager.dart
index c4c7e1f71d0676af54689de14f06b54f66b35da4..654bcbe134cfd6b37738e2db872db1d4570c7d5d 100644
--- a/pkg/analysis_server/lib/src/context_manager.dart
+++ b/pkg/analysis_server/lib/src/context_manager.dart
@@ -438,7 +438,7 @@ abstract class ContextManager {
endComputePackageMap();
for (String dependencyPath in packageMapInfo.dependencies) {
Resource resource = resourceProvider.getResource(dependencyPath);
- if (resource is File) {
+ if (resource is File && resource.exists) {
Paul Berry 2015/06/22 21:19:31 This introduces a race condition, because it's pos
danrubel 2015/06/22 21:54:46 I tried doing that in an earlier iteration of this
info.dependencySubscriptions.add(resource.changes
.listen((WatchEvent event) {
if (info.packageMapInfo != null &&
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698