Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2643)

Unified Diff: chrome/browser/history/chrome_history_client.h

Issue 1198373002: Split HistoryClient in two objects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1192403002
Patch Set: Add comments in ChromeHistoryBackendClient Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/chrome_history_client.h
diff --git a/chrome/browser/history/chrome_history_client.h b/chrome/browser/history/chrome_history_client.h
index b0fbfa32b4b8e9ecc18d42a6614061decf8d4a9b..41f823d7cfdd36e187ee12472ce7cf02c11d780a 100644
--- a/chrome/browser/history/chrome_history_client.h
+++ b/chrome/browser/history/chrome_history_client.h
@@ -8,8 +8,6 @@
#include "base/macros.h"
#include "components/history/core/browser/history_client.h"
-class Profile;
-
namespace bookmarks {
class BookmarkModel;
}
@@ -21,27 +19,15 @@ class ChromeHistoryClient : public history::HistoryClient {
explicit ChromeHistoryClient(bookmarks::BookmarkModel* bookmark_model);
~ChromeHistoryClient() override;
- // history::HistoryClient:
+ // history::HistoryClient implementation.
void Shutdown() override;
- void BlockUntilBookmarksLoaded() override;
- bool IsBookmarked(const GURL& url) override;
- void GetBookmarks(std::vector<history::URLAndTitle>* bookmarks) override;
bool CanAddURL(const GURL& url) override;
void NotifyProfileError(sql::InitStatus init_status) override;
- bool ShouldReportDatabaseError() override;
-#if defined(OS_ANDROID)
- void OnHistoryBackendInitialized(
- history::HistoryBackend* history_backend,
- history::HistoryDatabase* history_database,
- history::ThumbnailDatabase* thumbnail_database,
- const base::FilePath& history_dir) override;
- void OnHistoryBackendDestroyed(history::HistoryBackend* history_backend,
- const base::FilePath& history_dir) override;
-#endif
+ scoped_ptr<history::HistoryBackendClient> CreateBackendClient() override;
private:
- // The BookmarkModel, this should outlive ChromeHistoryClient. May be null
- // during testing.
+ // BookmarkModel instance providing access to bookmarks. May be null during
+ // testing but must outlive ChromeHistoryClient if non-null.
bookmarks::BookmarkModel* bookmark_model_;
DISALLOW_COPY_AND_ASSIGN(ChromeHistoryClient);
« no previous file with comments | « chrome/browser/history/chrome_history_backend_client.cc ('k') | chrome/browser/history/chrome_history_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698