Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1198363003: Do not unbreak alternative service in ClearAlternativeService. (Closed)

Created:
5 years, 6 months ago by Bence
Modified:
5 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not unbreak alternative service in ClearAlternativeService. Do not unbreak alternative service in HttpServerProperties::ClearAlternativeService(). * This is wrong, because only because an alternative service is not mapped to one origin any longer, if it was broken, it remains broken and should not be used for other origins. * QuicStreamFactory::ProcessGoingAwaySession() used to call ClearAlternativeService(), and right after that, SetAlternativeService, to mark an alternative service recently broken. Now QuicStreamFactory uses MarkAlternativeServiceRecentlyBroken calls instead, so this behavior in ClearAlternativeService is not required any more. * Note that despite what the TODO comment says, broken alternative services should remain in the mapping (until explicitly cleared by ClearAlternativeService). BUG=392575 Committed: https://crrev.com/8784b360bebebbe19e362cf487457513eb4eadb7 Cr-Commit-Position: refs/heads/master@{#335907}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M net/http/http_server_properties_impl.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan: PTAL. Thanks.
5 years, 6 months ago (2015-06-23 14:48:52 UTC) #2
Ryan Hamilton
lgtm
5 years, 6 months ago (2015-06-24 02:20:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198363003/20001
5 years, 6 months ago (2015-06-24 11:30:20 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-24 11:48:45 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 11:49:36 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8784b360bebebbe19e362cf487457513eb4eadb7
Cr-Commit-Position: refs/heads/master@{#335907}

Powered by Google App Engine
This is Rietveld 408576698