Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1198343004: Merge AddFastElement and AddFastDoubleElement (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Merge AddFastElement and AddFastDoubleElement BUG=v8:4137 LOG=n Committed: https://crrev.com/359142c330d21da95d64484cdc13e06c65866382 Cr-Commit-Position: refs/heads/master@{#29227}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix DCHECK #

Patch Set 4 : Remove JSObject:: prefix #

Patch Set 5 : #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -263 lines) Patch
M src/builtins.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/elements.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/lookup-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.h View 1 5 chunks +8 lines, -10 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 5 chunks +100 lines, -234 lines 0 comments Download
M src/objects-inl.h View 3 chunks +0 lines, -16 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-22 16:47:17 UTC) #2
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-23 11:03:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198343004/90001
5 years, 6 months ago (2015-06-23 11:09:10 UTC) #5
commit-bot: I haz the power
Committed patchset #6 (id:90001)
5 years, 6 months ago (2015-06-23 11:35:47 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 11:36:04 UTC) #7
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/359142c330d21da95d64484cdc13e06c65866382
Cr-Commit-Position: refs/heads/master@{#29227}

Powered by Google App Engine
This is Rietveld 408576698