runtime/vm/flow_graph_optimizer.cc - Issue 1198333004: Enable TryCreateICData optimization, disable crashing test in status file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 1198333004: Enable TryCreateICData optimization, disable crashing test in status file (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.cc

diff --git a/runtime/vm/flow_graph_optimizer.cc b/runtime/vm/flow_graph_optimizer.cc

index 85a91d2ea68bcf3a50288d4da4efe9aa53919a3e..09859de4d156b6aa43e87b52ab72f8862ad4423b 100644

--- a/runtime/vm/flow_graph_optimizer.cc

+++ b/runtime/vm/flow_graph_optimizer.cc

@@ -162,7 +162,6 @@ static bool IsNumberCid(intptr_t cid) {

bool FlowGraphOptimizer::TryCreateICData(InstanceCallInstr* call) {

- return false;

// TODO(srdjan): Investigate failures in:

// corelib/big_integer_arith_vm_test

// dart2js/members_test

« no previous file with comments | « no previous file | tests/corelib/corelib.status » ('j') | no next file with comments »