chrome/utility/importer/safari_importer.h - Issue 119833002: [Import] [OSX] Don't create an empty folder when importing from Safari with an empty Bookmarks Menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/utility/importer/safari_importer.h

Issue 119833002: [Import] [OSX] Don't create an empty folder when importing from Safari with an empty Bookmarks Menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/import/safari/empty_bookmarks_menu/README ('K') | « chrome/test/data/safari_import/Safari/WebpageIcons.db ('k') | chrome/utility/importer/safari_importer.mm » ('j') | chrome/utility/importer/safari_importer_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/utility/importer/safari_importer.h

diff --git a/chrome/utility/importer/safari_importer.h b/chrome/utility/importer/safari_importer.h

index ea64284105a873f7e5707cbf79772f85771430f6..09f714088afbe3ea53df190313beb936a64cb7be 100644

--- a/chrome/utility/importer/safari_importer.h

+++ b/chrome/utility/importer/safari_importer.h

@@ -46,6 +46,8 @@ class SafariImporter : public Importer {

private:

FRIEND_TEST_ALL_PREFIXES(SafariImporterTest, BookmarkImport);

+ FRIEND_TEST_ALL_PREFIXES(SafariImporterTest,

+ BookmarkImportWithEmptyBookmarksMenu);

FRIEND_TEST_ALL_PREFIXES(SafariImporterTest, FaviconImport);

FRIEND_TEST_ALL_PREFIXES(SafariImporterTest, HistoryImport);