Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1198323002: DevTools: category checkboxes are not disabled while running audits. (Closed)

Created:
5 years, 6 months ago by pfeldman
Modified:
5 years, 6 months ago
Reviewers:
lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: category checkboxes are not disabled while running audits. BUG=502954 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197666

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/devtools/front_end/audits/AuditLauncherView.js View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 7 (2 generated)
pfeldman
5 years, 6 months ago (2015-06-22 12:06:34 UTC) #2
lushnikov
https://codereview.chromium.org/1198323002/diff/1/Source/devtools/front_end/audits/AuditLauncherView.js File Source/devtools/front_end/audits/AuditLauncherView.js (right): https://codereview.chromium.org/1198323002/diff/1/Source/devtools/front_end/audits/AuditLauncherView.js#newcode176 Source/devtools/front_end/audits/AuditLauncherView.js:176: for (var child = this._categoriesElement.firstChild; child; child = child.nextSibling) ...
5 years, 6 months ago (2015-06-22 13:51:12 UTC) #3
lushnikov
lgtm
5 years, 6 months ago (2015-06-23 15:41:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1198323002/1
5 years, 6 months ago (2015-06-23 15:41:59 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 18:13:16 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197666

Powered by Google App Engine
This is Rietveld 408576698