chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm - Issue 1198313003: Fix the browser match rules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm

Issue 1198313003: Fix the browser match rules. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address sky@'s comment. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser_finder_chromeos_unittest.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm

index 7a1d74333503aed5e4b4d6d7f10124213a32aa60..fd11cf9c4b6c4eed9ca290e9091a831cb6112483 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm

@@ -100,8 +100,8 @@ class BookmarkEditorBaseControllerTest : public CocoaProfileTest {

}

Browser* CreateBrowser() override {

- Browser::CreateParams native_params(profile(), chrome::GetActiveDesktop());

- return chrome::CreateBrowserWithTestWindowForParams(&native_params);

+ Browser::CreateParams params(profile(), chrome::GetActiveDesktop());

+ return chrome::CreateBrowserWithTestWindowForParams(&params).release();

}

};