Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: chrome/browser/ui/browser_command_controller_unittest.cc

Issue 1198313003: Fix the browser match rules. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use scoped_ptr<Browser> instead. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_command_controller_unittest.cc
diff --git a/chrome/browser/ui/browser_command_controller_unittest.cc b/chrome/browser/ui/browser_command_controller_unittest.cc
index a80c7580269c2bda4d415bcf53fdbd1e101d70e7..d0d1093f58fbd016416614696aa1a960d0ba8967 100644
--- a/chrome/browser/ui/browser_command_controller_unittest.cc
+++ b/chrome/browser/ui/browser_command_controller_unittest.cc
@@ -249,8 +249,8 @@ TEST_F(BrowserCommandControllerTest, AvatarMenuAlwaysDisabledInIncognitoMode) {
// Create a new browser based on the off the record profile.
Browser::CreateParams profile_params(
original_profile->GetOffTheRecordProfile(), chrome::GetActiveDesktop());
- scoped_ptr<Browser> otr_browser(
- chrome::CreateBrowserWithTestWindowForParams(&profile_params));
+ scoped_ptr<Browser> otr_browser =
+ chrome::CreateBrowserWithTestWindowForParams(&profile_params);
chrome::BrowserCommandController command_controller(otr_browser.get());
const CommandUpdater* command_updater = command_controller.command_updater();
@@ -432,8 +432,8 @@ TEST_F(BrowserCommandControllerTest, IncognitoModeOnSigninAllowedPrefChange) {
// Create a new browser based on the off the record profile.
Browser::CreateParams profile_params(profile1->GetOffTheRecordProfile(),
chrome::GetActiveDesktop());
- scoped_ptr<Browser> browser2(
- chrome::CreateBrowserWithTestWindowForParams(&profile_params));
+ scoped_ptr<Browser> browser2 =
+ chrome::CreateBrowserWithTestWindowForParams(&profile_params);
chrome::BrowserCommandController command_controller(browser2.get());
const CommandUpdater* command_updater = command_controller.command_updater();

Powered by Google App Engine
This is Rietveld 408576698