Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: chrome/test/base/test_browser_window.cc

Issue 1198313003: Fix the browser match rules. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address msw@'s comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/test_browser_window.cc
diff --git a/chrome/test/base/test_browser_window.cc b/chrome/test/base/test_browser_window.cc
index 8bfc54c0b946c7117030471a426adce64233eb70..b2019a0b4eb3162f2d699e9c58338ca7cf0a6a17 100644
--- a/chrome/test/base/test_browser_window.cc
+++ b/chrome/test/base/test_browser_window.cc
@@ -6,9 +6,9 @@
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_list_observer.h"
+#include "ui/aura/window.h"
msw 2015/07/08 01:14:00 nit: this isn't needed, given the include in the h
xdai1 2015/07/08 21:34:21 Sorry missed this one. Removed it.
#include "ui/gfx/geometry/rect.h"
-
// Helpers --------------------------------------------------------------------
namespace chrome {
@@ -45,6 +45,23 @@ Browser* CreateBrowserWithTestWindowForParams(Browser::CreateParams* params) {
return new Browser(*params);
}
+#if defined(USE_AURA)
+Browser* CreateBrowserWithAuraTestWindowForParams(
+ const Browser::CreateParams& params) {
+ aura::Window* window = new aura::Window(nullptr);
msw 2015/07/08 01:14:00 nit: make |window| a scoped_ptr and pass into the
xdai1 2015/07/08 21:34:21 Done.
+ window->set_id(0);
+ window->SetType(ui::wm::WINDOW_TYPE_NORMAL);
+ window->Init(ui::LAYER_TEXTURED);
+ window->Show();
+
+ TestBrowserWindowAura* browser_window = new TestBrowserWindowAura(window);
+ browser_window->CreateBrowser(params);
+ new TestBrowserWindowOwner(browser_window);
+
+ return browser_window->browser();
+}
+#endif // defined(USE_AURA)
+
} // namespace chrome
@@ -231,3 +248,42 @@ void TestBrowserWindow::ExecuteExtensionCommand(
ExclusiveAccessContext* TestBrowserWindow::GetExclusiveAccessContext() {
return nullptr;
}
+
+#if defined(USE_AURA)
+
+// TestBrowserWindowAura -------------------------------------------------------
+
+TestBrowserWindowAura::TestBrowserWindowAura(aura::Window* native_window)
+ : native_window_(native_window) {
+}
+
+TestBrowserWindowAura::~TestBrowserWindowAura() {
+}
+
+gfx::NativeWindow TestBrowserWindowAura::GetNativeWindow() const {
+ return native_window_.get();
+}
+
+void TestBrowserWindowAura::Show() {
+ native_window_->Show();
+}
+
+void TestBrowserWindowAura::Hide() {
+ native_window_->Hide();
+}
+
+gfx::Rect TestBrowserWindowAura::GetBounds() const {
+ return native_window_->bounds();
+}
+
+Browser* TestBrowserWindowAura::browser() {
+ return browser_;
+}
+
+void TestBrowserWindowAura::CreateBrowser(const Browser::CreateParams& params) {
+ Browser::CreateParams create_params = params;
+ create_params.window = this;
+ browser_ = new Browser(create_params);
+}
+
+#endif

Powered by Google App Engine
This is Rietveld 408576698