chrome/browser/ui/browser_finder.cc - Issue 1198313003: Fix the browser match rules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_finder.cc

Issue 1198313003: Fix the browser match rules. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_finder.cc

diff --git a/chrome/browser/ui/browser_finder.cc b/chrome/browser/ui/browser_finder.cc

index 4b5fe8eb6a6d62139e25f8a57567f22db9e1bb29..b8259c8fdb797c54c9f807aabfbd3666b14ddf3d 100644

--- a/chrome/browser/ui/browser_finder.cc

+++ b/chrome/browser/ui/browser_finder.cc

@@ -60,7 +60,8 @@ bool BrowserMatches(Browser* browser,

shown_user_id.empty()

? nullptr

: multi_user_util::GetProfileFromUserID(shown_user_id);

- matches_profile &= !shown_profile || shown_profile == profile;

+ matches_profile &= !shown_profile ||

+ shown_profile == profile->GetOriginalProfile();

msw 2015/06/23 17:08:51 Should you use shown_profile->GetOriginalProfile()

msw 2015/06/23 17:08:51 Should this change be limited to when kMatchOrigin

xdai1 2015/06/30 16:16:49 Sorry my fault. Should compare with original profi

}

#endif

« no previous file with comments | « no previous file | no next file » | no next file with comments »