Fix the browser match rules.

chrome/browser/ui/ash/window_positioner_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/window_positioner.h"
 
 #include "ash/shell.h"
 #include "ash/test/ash_test_base.h"
 #include "ash/test/test_shell_delegate.h"
 #include "ash/wm/window_resizer.h"
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/host_desktop.h"
 #include "chrome/test/base/test_browser_window.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/test/render_view_test.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/aura/env.h"
 #include "ui/aura/test/test_windows.h"
 #include "ui/aura/window_event_dispatcher.h"
 #include "ui/gfx/screen.h"
 
 namespace ash {
 namespace test {
 
-namespace {
-
-// A browser window proxy which is able to associate an aura native window with
-// it.
-class TestBrowserWindowAura : public TestBrowserWindow {
- public:
-  explicit TestBrowserWindowAura(aura::Window* native_window);
-  ~TestBrowserWindowAura() override;
-
-  gfx::NativeWindow GetNativeWindow() const override { return native_window_; }
-
- private:
-  gfx::NativeWindow native_window_;
-
-  DISALLOW_COPY_AND_ASSIGN(TestBrowserWindowAura);
-};
-
-TestBrowserWindowAura::TestBrowserWindowAura(aura::Window *native_window)
-    : native_window_(native_window) {
-}
-
-TestBrowserWindowAura::~TestBrowserWindowAura() {}
-
-}  // namespace
-
 // A test class for preparing window positioner tests - it creates a testing
 // base by adding a window and a popup which can be independently
 // positioned to see where the positioner will place the window.
 class WindowPositionerTest : public AshTestBase {
  public:
   WindowPositionerTest();
 
   void SetUp() override;
   void TearDown() override;
 
  protected:
-  aura::Window* window() { return window_.get(); }
-  aura::Window* popup() { return popup_.get(); }
+  aura::Window* window() { return browser_->window()->GetNativeWindow(); }
+  aura::Window* popup() { return browser_popup_->window()->GetNativeWindow(); }
 
-  Browser* window_browser() { return window_owning_browser_.get(); }
-  Browser* popup_browser() { return popup_owning_browser_.get(); }
-
-  WindowPositioner* window_positioner() { return window_positioner_; }
+  WindowPositioner* window_positioner() { return window_positioner_.get(); }
 
   // The positioner & desktop's used grid alignment size.
   const int grid_size_;
 
  private:
-  WindowPositioner* window_positioner_;
+  scoped_ptr<WindowPositioner> window_positioner_;
 
-  // These two need to be deleted after everything else is gone.
   TestingProfile profile_;
 
-  // These get created for each session.
-  scoped_ptr<aura::Window> window_;
-  scoped_ptr<aura::Window> popup_;
-
-  scoped_ptr<BrowserWindow> browser_window_;
-  scoped_ptr<BrowserWindow> browser_popup_;
-
-  scoped_ptr<Browser> window_owning_browser_;
-  scoped_ptr<Browser> popup_owning_browser_;
+  scoped_ptr<Browser> browser_;
+  scoped_ptr<Browser> browser_popup_;
 
   DISALLOW_COPY_AND_ASSIGN(WindowPositionerTest);
 };
 
 WindowPositionerTest::WindowPositionerTest()
-    : grid_size_(WindowPositioner::kMinimumWindowOffset),
-      window_positioner_(NULL) {
+    : grid_size_(WindowPositioner::kMinimumWindowOffset) {
 }
 
 void WindowPositionerTest::SetUp() {
   AshTestBase::SetUp();
   // Create some default dummy windows.
-  window_.reset(CreateTestWindowInShellWithId(0));
-  window_->SetBounds(gfx::Rect(16, 32, 640, 320));
-  popup_.reset(CreateTestWindowInShellWithId(1));
-  popup_->SetBounds(gfx::Rect(16, 32, 128, 256));
+  scoped_ptr<aura::Window> window(CreateTestWindowInShellWithId(0));
+  window->SetBounds(gfx::Rect(16, 32, 640, 320));
+  scoped_ptr<aura::Window> popup(CreateTestWindowInShellWithId(1));
+  popup->SetBounds(gfx::Rect(16, 32, 128, 256));
 
   // Create a browser for the window.
-  browser_window_.reset(new TestBrowserWindowAura(window_.get()));
   Browser::CreateParams window_params(&profile_,
                                       chrome::HOST_DESKTOP_TYPE_ASH);
-  window_params.window = browser_window_.get();
-  window_owning_browser_.reset(new Browser(window_params));
+  browser_ = chrome::CreateBrowserWithAuraTestWindowForParams(window.Pass(),
+                                                              &window_params);
 
   // Creating a browser for the popup.
-  browser_popup_.reset(new TestBrowserWindowAura(popup_.get()));
   Browser::CreateParams popup_params(Browser::TYPE_POPUP, &profile_,
                                      chrome::HOST_DESKTOP_TYPE_ASH);
-  popup_params.window = browser_popup_.get();
-  popup_owning_browser_.reset(new Browser(popup_params));
+  browser_popup_ = chrome::CreateBrowserWithAuraTestWindowForParams(
+      popup.Pass(), &popup_params);

[msw, 2015/07/09 22:37:37]

nit: is this formatted correctly?

[xdai1, 2015/07/09 23:45:40]

Yes, it is.

 
   // We hide all windows upon start - each user is required to set it up
   // as he needs it.
-  window()->Hide();
-  popup()->Hide();
-  window_positioner_ = new WindowPositioner();
+  browser_->window()->GetNativeWindow()->Hide();

[msw, 2015/07/09 22:37:37]

nit: use window() and popup() here and below.

[xdai1, 2015/07/09 23:45:40]

Done. Renamed local variable |window| and |popup| to avoid conflict. 

+  browser_popup_->window()->GetNativeWindow()->Hide();
+  window_positioner_.reset(new WindowPositioner());
 }
 
 void WindowPositionerTest::TearDown() {
   // Since the AuraTestBase is needed to create our assets, we have to
   // also delete them before we tear it down.
-  window_owning_browser_.reset(NULL);
-  popup_owning_browser_.reset(NULL);
-
-  browser_window_.reset(NULL);
-  browser_popup_.reset(NULL);
-
-  window_.reset(NULL);
-  popup_.reset(NULL);
-
+  browser_.reset();
+  browser_popup_.reset();
+  window_positioner_.reset();
   AshTestBase::TearDown();
-  delete window_positioner_;
-  window_positioner_ = NULL;
 }
 
 int AlignToGridRoundDown(int location, int grid_size) {
   if (grid_size <= 1 || location % grid_size == 0)
     return location;
   return location / grid_size * grid_size;
 }
 
 TEST_F(WindowPositionerTest, cascading) {
   const gfx::Rect work_area =
@@ skipping 119 matching lines @@
 
   // Check that the popup is placed full screen.
   gfx::Rect full = window_positioner()->GetPopupPosition(pop_position);
   EXPECT_EQ(gfx::Rect(work_area.x(), work_area.y(),
                       pop_position.width(), pop_position.height()),
                       full);
 }
 
 }  // namespace test
 }  // namespace ash