Fix the browser match rules.

chrome/test/base/test_browser_window.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_BASE_TEST_BROWSER_WINDOW_H_
 #define CHROME_TEST_BASE_TEST_BROWSER_WINDOW_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "build/build_config.h"
 #include "chrome/browser/download/test_download_shelf.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/location_bar/location_bar.h"
 
+#if defined(USE_AURA)
+#include "ui/aura/window.h"
+#endif
+
 class LocationBarTesting;
 class OmniboxView;
 
 namespace extensions {
 class Extension;
 }
 
 // An implementation of BrowserWindow used for testing. TestBrowserWindow only
 // contains a valid LocationBar, all other getters return NULL.
 // See BrowserWithTestWindowTest for an example of using this class.
@@ skipping 159 matching lines @@
    private:
     DISALLOW_COPY_AND_ASSIGN(TestLocationBar);
   };
 
   TestDownloadShelf download_shelf_;
   TestLocationBar location_bar_;
 
   DISALLOW_COPY_AND_ASSIGN(TestBrowserWindow);
 };
 
+#if defined(USE_AURA)
+// A browser window proxy with an associated Aura native window.
+class TestBrowserWindowAura : public TestBrowserWindow {
+ public:
+  explicit TestBrowserWindowAura(scoped_ptr<aura::Window> native_window);
+  ~TestBrowserWindowAura() override;
+
+  // TestBrowserWindow overrides:
+  gfx::NativeWindow GetNativeWindow() const override;
+  void Show() override;
+  void Hide() override;
+  gfx::Rect GetBounds() const override;
+
+  Browser* CreateBrowser(const Browser::CreateParams& params);
+
+ private:
+  Browser* browser_;  // not owned
+  scoped_ptr<aura::Window> native_window_;
+
+  DISALLOW_COPY_AND_ASSIGN(TestBrowserWindowAura);
+};
+#endif  // defined(USE_AURA)
+
 namespace chrome {
 
 // Helper that handle the lifetime of TestBrowserWindow instances.
 Browser* CreateBrowserWithTestWindowForParams(Browser::CreateParams* params);
 
+#if defined(USE_AURA)
+// Helper that creates a browser which has a native aura window. It also handles
+// the lifetime of TestBrowserWindowAura.
+Browser* CreateBrowserWithAuraTestWindowForParams(
+    const Browser::CreateParams& params);
+
+// Helper that creates a browser for a native aura window. It also handles the
+// lifetime of TestBrowserWindowAura.
+Browser* CreateBrowserForAuraTestWindowAndParams(

[msw, 2015/07/08 23:58:00]

Could we just have this single function, and callers could just pass in a null
window if they want one created for them?

+    scoped_ptr<aura::Window> window,
+    const Browser::CreateParams& params);
+
+#endif  // defined(USE_AURA)
+
 }  // namespace chrome
 
 #endif  // CHROME_TEST_BASE_TEST_BROWSER_WINDOW_H_